Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add COMPOSE_FILE env variable #1753

Merged

Conversation

AhmedGrati
Copy link
Contributor

@AhmedGrati AhmedGrati commented Nov 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR aims to add COMPOSE_FILE env variable to specify files to convert. e.g.:

COMPOSE_FILE="docker-compose.yaml alternative-docker-compose.yaml" kompose convert

Which issue(s) this PR fixes:

Fixes #1728

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from kadel and sebgoa November 5, 2023 14:08
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2023
@AhmedGrati
Copy link
Contributor Author

/cc @cdrage

@k8s-ci-robot k8s-ci-robot requested a review from cdrage November 5, 2023 14:08
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
@AhmedGrati AhmedGrati force-pushed the feat-add-COMPOSE_FILE-env-variable branch from d0107a9 to 867adcf Compare November 5, 2023 14:31
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Absolutely no changes requested and everything LGTM!

@cdrage
Copy link
Member

cdrage commented Nov 7, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 293f232 into kubernetes:main Nov 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] COMPOSE_FILE env var is not honored
4 participants