Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from libcompose to compose-go #1547

Merged
merged 2 commits into from
Jan 12, 2023
Merged

feat: migrate from libcompose to compose-go #1547

merged 2 commits into from
Jan 12, 2023

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Dec 22, 2022

libcompose has been deprecated since summer 2021 in favor of https://github.com/compose-spec/compose-go. Kompose should now be able to load all versions of compose.

Closes #1523
Closes #1518
Closes #1464
Closes #1152
Closes #1371

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 22, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Lctrs!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 22, 2022
@cdrage
Copy link
Member

cdrage commented Jan 10, 2023

Oh man, 3 weeks and no review. I'm so sorry. I'm going to run the tests now and see if they pass and test this out tonight. Ping me again if I don't get around to it.

Thanks again for the AMAZING contribution, this is going to help out a lot in terms of conversion.

@Lctrs
Copy link
Contributor Author

Lctrs commented Jan 10, 2023

@cdrage I wanted to reserve the last commit for another PR, but let's try fixing the CI with it :)

Lctrs added 2 commits January 11, 2023 00:43
libcompose has been deprecated since summer 2021 in favor of https://github.com/compose-spec/compose-go.
Kompose should now be able to load all versions of compose.
golint has been deprecated. Recommended replacement is staticcheck.
@Lctrs
Copy link
Contributor Author

Lctrs commented Jan 11, 2023

@cdrage should be good now :)

@cdrage
Copy link
Member

cdrage commented Jan 11, 2023

@cdrage should be good now :)

thank you! out of bandwidth today, but I'll be testing it out tomorrow :) (i'm running the tests though right now).

@cdrage
Copy link
Member

cdrage commented Jan 12, 2023

Absolutely awesome and the code looks great! My only concern is using dominikh/staticcheck for the static checking. Unfortunately the development looks to have slowed down on that side and I much prefer we use golint instead.

Any way we can compromise and use golint instead? My concern is that dominikh/staticcheck is non-standard as most projects have implemented the official Go lint supported instead.

@Lctrs
Copy link
Contributor Author

Lctrs commented Jan 12, 2023

If I'm not mistaken, the source code of golint resides here : https://github.com/golang/lint.
The repo is archived, and on the first lines of the README, it is stated that it is frozen and deprecated, and that the suggested replacement is staticcheck.

staticcheck doesn't seem so dead to me as the last commit on their repo (https://github.com/dominikh/go-tools) is from december 9th 2022.

@cdrage
Copy link
Member

cdrage commented Jan 12, 2023

If I'm not mistaken, the source code of golint resides here : https://github.com/golang/lint. The repo is archived, and on the first lines of the README, it is stated that it is frozen and deprecated, and that the suggested replacement is staticcheck.

staticcheck doesn't seem so dead to me as the last commit on their repo (https://github.com/dominikh/go-tools) is from december 9th 2022.

You're totally right! I had thought that golint was merged into the go source code, and now that you've brought it up, I'll go ahead and change the other project I'm working on to staticcheck.

After reviewing this code today, I'm happy to merge it! Thanks so much for this awesome work. You've brought Kompose back to 2023 standards.

@cdrage cdrage merged commit 2ad5745 into kubernetes:master Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, Lctrs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@Lctrs Lctrs deleted the feature/compose-go branch January 12, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants