-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate from libcompose to compose-go #1547
Conversation
|
Welcome @Lctrs! |
Oh man, 3 weeks and no review. I'm so sorry. I'm going to run the tests now and see if they pass and test this out tonight. Ping me again if I don't get around to it. Thanks again for the AMAZING contribution, this is going to help out a lot in terms of conversion. |
@cdrage I wanted to reserve the last commit for another PR, but let's try fixing the CI with it :) |
libcompose has been deprecated since summer 2021 in favor of https://github.com/compose-spec/compose-go. Kompose should now be able to load all versions of compose.
golint has been deprecated. Recommended replacement is staticcheck.
@cdrage should be good now :) |
thank you! out of bandwidth today, but I'll be testing it out tomorrow :) (i'm running the tests though right now). |
Absolutely awesome and the code looks great! My only concern is using dominikh/staticcheck for the static checking. Unfortunately the development looks to have slowed down on that side and I much prefer we use Any way we can compromise and use |
If I'm not mistaken, the source code of golint resides here : https://github.com/golang/lint. staticcheck doesn't seem so dead to me as the last commit on their repo (https://github.com/dominikh/go-tools) is from december 9th 2022. |
You're totally right! I had thought that golint was merged into the go source code, and now that you've brought it up, I'll go ahead and change the other project I'm working on to staticcheck. After reviewing this code today, I'm happy to merge it! Thanks so much for this awesome work. You've brought Kompose back to 2023 standards. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, Lctrs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
libcompose has been deprecated since summer 2021 in favor of https://github.com/compose-spec/compose-go. Kompose should now be able to load all versions of compose.
Closes #1523
Closes #1518
Closes #1464
Closes #1152
Closes #1371