Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests output files #101

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Conversation

surajssd
Copy link
Member

With the recent changes in the output format as List, updated tests as well so they validate on the new format of output.

@janetkuo
Copy link
Member

janetkuo commented Aug 11, 2016

Which kompose binary is the test using? Did it rebuild the binary before the test?

@surajssd
Copy link
Member Author

Yes binary was rebuilt before test and it is put in system's PATH.

@ngtuna
Copy link
Contributor

ngtuna commented Aug 12, 2016

Hey @surajssd , just a quick check (I am missing something, sorry that my head is struggling...). Did we cover the docker-compose-no-image.yml case in master branch? I got this fail (only this):

===> Starting test <===
convert::expect_failure: Running: 'kompose convert --stdout -f /home/travis/gopath/src/github.com/skippbox/kompose/script/test/fixtures/etherpad/docker-compose-no-image.yml'
FAIL: no error output, returned exit status 0

@ngtuna
Copy link
Contributor

ngtuna commented Aug 12, 2016

Ah I found it. Still open #80. So how can we bypass this case in the current travis-ci test ? Or just ignore it and merge like @kadel did yesterday?

@surajssd
Copy link
Member Author

@ngtuna yes i think we need to ignore it for now or if you suggest I can comment the test for now and then uncomment it when it gets fixed?

@ngtuna
Copy link
Contributor

ngtuna commented Aug 12, 2016

@surajssd yes please do.

With the recent changes in the output format as List,
updated tests as well so they validate on the new format of output.
@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2016
@surajssd
Copy link
Member Author

@ngtuna thanks :)

@surajssd surajssd merged commit 3fcfb71 into kubernetes:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants