Tracking card for new deploy keys in v3

[cdrage]

We have to cover the new keys in deploy for v3 of Docker Compose, at the moment, we only have mem_limit complete.

New keys:

• mode
• replicas
• placement
• update_config
• resources
• restart_policy
• labels
• cpus (under 'resources')
• memory (under 'resources')

[surajnarwade]

I will take replicas key

[cdrage]

@surajnarwade I already started work on it, sorry :( I'm setting up a separate function so that we can parse these keys easier.

[surajnarwade]

@cdrage okay no worries

[ashetty1]

@cdrage also, Ports in long syntax?

[cdrage]

@ashetty1 Open up another issue for that. But it's v3.2 and it's not even integrated into moby/moby yet.

[cdrage]

Hey @surajnarwade wanna take this up and see how we can implement the deploy side of things? I was starting work on this but got side-tracked by the 1.0.0 release

[surajnarwade]

@cdrage, sure, can you point me towards where you start

[cdrage]

@surajnarwade https://github.com/docker/cli/blob/master/cli/compose/types/types.go#L159 would be a good start. Luckily we're able to easily access the deploy keys via v3.go 😄

[surajnarwade]

I will take restart-policy as well

[surajssd]

this was closed by #664 this by mistake, if this is a tracking card @surajnarwade please don't add the fixes thing in your PR because this will get closed on the next PR that says that again

[surajnarwade]

@cdrage @surajssd , I think mode is swarm specific command, it will be better if we can add it to unsupported keys

[cdrage]

Three more to-go.

@surajnarwade

I have added mode here: #771 you said it couldn't be done, but I did it! 👍

[surajnarwade]

@cdrage , that's good.
I have investigated on placement key, I found only two mappings,

• engine.labels.operatingsystem is equivalent to beta.kubernetes.io/os
• node.hostname is equivalent to kubernetes.io/hostname

Does this makes sense ?
I havn't found any other mappings.

[cdrage]

@surajnarwade that makes sense. everything else we can warn / info out.

[cdrage]

Placement has been completed. 1 more to-go.

[surajnarwade]

@cdrage since update_config has no direct mapping in kubernetes, Let's close this issue

[cdrage]

@surajnarwade Before that, we will have to update the conversion matrix documentation.

[surajnarwade]

@cdrage since conversion matrix is also updated now, Let's close the issue :)