Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing --from-bundles (bool) to --bundle-file (string) #53

Closed
janetkuo opened this issue Jul 22, 2016 · 4 comments
Closed

Consider changing --from-bundles (bool) to --bundle-file (string) #53

janetkuo opened this issue Jul 22, 2016 · 4 comments
Assignees

Comments

@janetkuo
Copy link
Member

How about we make the flag for specifying bundles to something similar to --file (e.g. --bundle-file)? It'll be easier to specify than --from-bundles + --file=xxx. We can validate the flags so that either --file or --bundle-file can be specified at a time.

@ngtuna
Copy link
Contributor

ngtuna commented Jul 22, 2016

+1. when adding --from-bundles flag I was just thinking about reusing --file flag. Could you make a commit for this?

@janetkuo
Copy link
Member Author

Sure
On Thu, Jul 21, 2016 at 7:30 PM Tuna notifications@github.com wrote:

+1. when adding --from-bundles flag I was just thinking about reusing
--file flag. Could you make a commit for this?


You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEpqQ0kV4Xg4hzgoc7scb2OhlRBBDzGFks5qYCtKgaJpZM4JSVqW
.

@sebgoa
Copy link
Contributor

sebgoa commented Jul 22, 2016

so +1 I confirm, this is not very intuitive:

$ ./kompose convert --from-bundles ./docker-compose-bundle.dsb 
FATA[0000] Failed to parse bundles file: %!(EXTRA *errors.errorString=JSON syntax error at byte 1: invalid character 'm' looking for beginning of value) 
$ ./kompose convert --from-bundles --file docker-compose-bundle.dsb 
file "web-svc.json" created
file "redis-svc.json" created
file "web-deployment.json" created
file "redis-deployment.json" created

@ngtuna
Copy link
Contributor

ngtuna commented Jul 22, 2016

@janetkuo: after you finish the patch to introduce --bundle-file flag, I will update README for both bundlefile and compose v2 guidances

#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants