Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specifying service type right now is very docker-compose specific #273

Closed
surajssd opened this issue Nov 7, 2016 · 1 comment
Closed

specifying service type right now is very docker-compose specific #273

surajssd opened this issue Nov 7, 2016 · 1 comment
Assignees
@surajssd

Comments

@surajssd
Copy link
Member

surajssd commented Nov 7, 2016

We use labels from docker-compose to specify type of service (e.g. kompose.service.type: nodeport) that gets created and this gets mapped to annotatations internally but then we can do this cleanly by adding one more directive in ServiceConfig named ServiceType string so that at loader stage itself we load this variable and in transformation we don't need to do annotation checking!

So basically now we add one vairable to ServiceConfig and move code from CreateService to respective loaders.
@ngtuna
Copy link
Contributor

ngtuna commented Nov 7, 2016

+1. I think that makes sense.

@surajssd surajssd self-assigned this Nov 9, 2016
surajssd added a commit to surajssd/kompose that referenced this issue Nov 9, 2016
@surajssd
Generic service type handler for kompose
e12bf09 
Moved label handling code from Transformer to loader,
to make it generic to handle creating service types.

Added new attribute to ServiceConfig which gets populated
in loader.

Fixes kubernetes#273
@surajssd surajssd mentioned this issue Nov 9, 2016
Merged
surajssd added a commit to surajssd/kompose that referenced this issue Nov 16, 2016
@surajssd
Generic service type handler for kompose
bb9e4fb 
Moved label handling code from Transformer to loader,
to make it generic to handle creating service types.

Added new attribute to ServiceConfig which gets populated
in loader.

Fixes kubernetes#273
procrypt pushed a commit to procrypt/kompose that referenced this issue Nov 25, 2016
@surajssd
Generic service type handler for kompose
2fec080 
Moved label handling code from Transformer to loader,
to make it generic to handle creating service types.

Added new attribute to ServiceConfig which gets populated
in loader.

Fixes kubernetes#273
procrypt pushed a commit to procrypt/kompose that referenced this issue Nov 25, 2016
@surajssd
Generic service type handler for kompose
c759850 
Moved label handling code from Transformer to loader,
to make it generic to handle creating service types.

Added new attribute to ServiceConfig which gets populated
in loader.

Fixes kubernetes#273
procrypt pushed a commit to procrypt/kompose that referenced this issue Dec 5, 2016
@surajssd
Generic service type handler for kompose
83896af 
Moved label handling code from Transformer to loader,
to make it generic to handle creating service types.

Added new attribute to ServiceConfig which gets populated
in loader.

Fixes kubernetes#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajssd surajssd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ngtuna @surajssd