Merge pull request #68 from surajssd/missing-port-info

Warning on missing port information and no service created
kubernetes · Jul 28, 2016 · 87270e3 · 87270e3
2 parents 0b2426d + e0bcd32
commit 87270e3
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/cli/app/app.go b/cli/app/app.go
@@ -932,10 +932,16 @@ func komposeConvert(komposeObject KomposeObject, opt convertOptions) {
 			logrus.Fatalf(err.Error())
 		}
 
-		// convert datasvc to json / yaml
-		datasvc, err := transformer(sc, opt.generateYaml)
-		if err != nil {
-			logrus.Fatalf(err.Error())
+		var datasvc []byte
+		// If ports not provided in configuration we will not make service
+		if len(ports) == 0 {
+			logrus.Warningf("[%s] Service cannot be created because of missing port.", name)
+		} else {
+			// convert datasvc to json / yaml
+			datasvc, err = transformer(sc, opt.generateYaml)
+			if err != nil {
+				logrus.Fatalf(err.Error())
+			}
 		}
 
 		// convert OpenShift DeploymentConfig to json / yaml