GCP: ensure prow-build can administer KMS keys #6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @BenTheElder |
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
area/bash
pwschuurman
force-pushed
the
cloudkms-admin-prow-build
branch
from
a9c1207 to
48d621e
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This is running |
|
Done in the main e2e pool. Still running for the rest. |
|
Confirming: done for all projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the prow-build SA use KMS keys. PDCSI e2e tests use the prow-build SA by default to authenticate against the cloudkms API.
See https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gcp-compute-persistent-disk-csi-driver/1762/pull-gcp-compute-persistent-disk-csi-driver-e2e/1806716408805986304
This is analogous to the existing cluster IAM model, where
pr-kubekins@kubernetes-jenkins-pull.iam.gserviceaccount.comhadroles/cloudkms.adminpermission.