Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New secret to migrate from a legacy AWS account #5845

Merged
merged 1 commit into from
Sep 13, 2023
Merged

New secret to migrate from a legacy AWS account #5845

merged 1 commit into from
Sep 13, 2023

Conversation

dims
Copy link
Member

@dims dims commented Sep 13, 2023 •
edited
Loading

related to #5194

@dims
New secret to migrate from a legacy AWS account
c7c92e2 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2023
@dims
Copy link
Member Author

dims commented Sep 13, 2023

/assign @ameukam @tzneal @upodroid

tzneal
tzneal approved these changes Sep 13, 2023
View reviewed changes
Copy link

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tzneal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit de6d3bd into kubernetes:main Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

@pkprzekwas pkprzekwas Awaiting requested review from pkprzekwas

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@tzneal tzneal

@ameukam ameukam

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @k8s-ci-robot @tzneal @ameukam @upodroid