audit: update as of 2021-10-14 #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/k8s-infra
k8s-infra-ci-robot
changed the title
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
f3321bd to
dd4ca3f
Compare
k8s-ci-robot
added
size/M
spiffxp
reviewed
Oct 14, 2021
| "bindings": [ | ||
| { | ||
| "members": [ | ||
| "serviceAccount:kubernetes-public.svc.id.goog[test-pods/tf-monitoring-deployer]" |
There was a problem hiding this comment.
@ameukam I think you want this to be k8s-infra-prow-build-trusted, or are you intending on scheduling to test-pods in the aaa cluster?
There was a problem hiding this comment.
Huh. You're right. I'm gonna fix when tomorrow in my morning.
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
2 times, most recently
from
6b05040 to
cc1d366
Compare
k8s-ci-robot
added
size/L
k8s-infra-ci-robot
force-pushed
the
autoaudit-prow
branch
from
cc1d366 to
2a5f6d4
Compare
spiffxp
approved these changes
Oct 14, 2021
Comment on lines
+1
to
+11
| { | ||
| "createTime": "2021-10-14T17:18:53.028Z", | ||
| "lifecycleState": "ACTIVE", | ||
| "name": "k8s-infra-kubernetes-io", | ||
| "parent": { | ||
| "id": "758905017065", | ||
| "type": "organization" | ||
| }, | ||
| "projectId": "k8s-infra-kubernetes-io", | ||
| "projectNumber": "297021770930" | ||
| } |
Comment on lines
+4
to
+7
| "members": [ | ||
| "user:spiffxp@google.com" | ||
| ], | ||
| "role": "roles/owner" |
There was a problem hiding this comment.
Hmmm need to change this to be the org admins group
Comment on lines
+1
to
+11
| { | ||
| "createTime": "2021-10-14T16:37:21.358Z", | ||
| "lifecycleState": "ACTIVE", | ||
| "name": "k8s-staging-sig-auth", | ||
| "parent": { | ||
| "id": "758905017065", | ||
| "type": "organization" | ||
| }, | ||
| "projectId": "k8s-staging-sig-auth", | ||
| "projectNumber": "26063304352" | ||
| } |
There was a problem hiding this comment.
Staging project created by #2921
| @@ -0,0 +1,20 @@ | |||
| gs://k8s-infra-tf-gcp/ : | |||
| @@ -0,0 +1,20 @@ | |||
| gs://k8s-infra-tf-monitoring/ : | |||
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-ci-robot, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit Updates sig-k8s-infra