Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform/kubernetes-public: add k8s-prod-readiness dataset and group #2717

Merged
merged 1 commit into from
Sep 14, 2021
Merged

terraform/kubernetes-public: add k8s-prod-readiness dataset and group #2717

merged 1 commit into from
Sep 14, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 13, 2021 •
edited
Loading

Related:

Adds a k8s-prod-readiness bigquery dataset owned by a new k8s-infra-prod-readiness@kubernetes.io group that is populated by the current PRR approvers (I happened to find an e-mail for each person in other groups already(

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. wg/k8s-infra labels Sep 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 13, 2021

/cc @ameukam
/hold
for @ameukam's take
/cc @johnbelamaric
to confirm this satisfies the request

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@ameukam
Copy link
Member

ameukam commented Sep 13, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 14, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 14, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
spiffxp
spiffxp commented Sep 14, 2021
View reviewed changes
infra/gcp/terraform/kubernetes-public/k8s-prod-readiness.tf
}
}

resource "google_bigquery_dataset_iam_policy" "prod_readiness_dataset" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to s/prod-readiness/prod_readiness

@spiffxp
Copy link
Member Author

spiffxp commented Sep 14, 2021

/hold cancel
PTAL

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
@johnbelamaric
Copy link
Member

thanks, yes, I think this should give us what we need

@spiffxp spiffxp mentioned this pull request Sep 14, 2021
Merged
@ameukam
Copy link
Member

ameukam commented Sep 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit c766caf into kubernetes:main Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 14, 2021
@spiffxp spiffxp deleted the k8s-prod-readiness branch September 14, 2021 19:22
@spiffxp spiffxp mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@thockin thockin Awaiting requested review from thockin

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @k8s-ci-robot @ameukam @johnbelamaric