Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: update spiffxp membership #2673

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 8, 2021

Broadly:

  • drop spiffxp google.com from groups unless they're admin groups
    • k8s-infra-rbac-slack-infra
    • k8s-infra-staging-infra-tools
    • k8s-infra-staging-e2e-test-images
    • k8s-infra-staging-k8s-gsm-tools
    • k8s-infra-gcp-auditors
  • drop spiffxp gmail.com from groups spiffxp doesn't work in
    • k8s-infra-rbac-sippy
    • k8s-infra-staging-kops
  • drop spiffxp gmail.com from admin groups
    • k8s-infra-gcp-accounting
  • swap google.com for gmail.com in non-admin groups spiffxp does work in
    • k8s-infra-staging-kubetest2

Motivated by trying to make my gmail.com account as read-only as
possible for purposes of experimenting with data studio, while giving
appropriate admin access for sig testing subprojects

Broadly:
- drop spiffxp google.com from groups unless they're admin groups
  - k8s-infra-rbac-slack-infra
  - k8s-infra-staging-infra-tools
  - k8s-infra-staging-e2e-test-images
  - k8s-infra-staging-k8s-gsm-tools
  - k8s-infra-gcp-auditors
- drop spiffxp gmail.com from groups spiffxp doesn't work in
  - k8s-infra-rbac-sippy
  - k8s-infra-staging-kops
- drop spiffxp gmail.com from admin groups
  - k8s-infra-gcp-accounting
- swap google.com for gmail.com in non-admin groups spiffxp does work in
  - k8s-infra-staging-kubetest2
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/k8s-infra labels Sep 8, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 8, 2021

/cc @BenTheElder @amwat

@spiffxp
Copy link
Member Author

spiffxp commented Sep 8, 2021

/cc @dims @ameukam

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims September 8, 2021 16:23
@ameukam
Copy link
Member

ameukam commented Sep 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit d2184e5 into kubernetes:main Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
@spiffxp spiffxp deleted the update-spiffxp-groups branch September 8, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants