Temporary project artificat infrastructure #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/hold
ameukam
commented
Apr 22, 2021
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
ameukam
force-pushed
the
artifact-mgmt-sanbox
branch
from
41a2122 to
b3f1582
Compare
k8s-ci-robot
added
size/L
ameukam
commented
Apr 22, 2021
Comment on lines
27
to
36
| resource "google_project" "project" { | ||
| name = local.project_id | ||
| project_id = local.project_id | ||
| org_id = data.google_organization.org.org_id | ||
| } |
There was a problem hiding this comment.
Since this is temporary, I don't think we should use the terraform module gke-project. Open to suggestions.
ameukam
commented
Apr 22, 2021
|
No objections. Leaving hold for Aaron JIC /lgtm |
k8s-ci-robot
added
the
lgtm
spiffxp
suggested changes
Apr 23, 2021
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
infra/gcp/clusters/projects/artifact-management-sandbox/main.tf
Outdated
Show resolved
Hide resolved
|
|
||
| backend "gcs" { | ||
| bucket = "k8s-infra-clusters-terraform" | ||
| prefix = "artifact-management-sandbox" |
There was a problem hiding this comment.
ack, I will try to capture this as part of #1952
k8s-ci-robot
removed
the
lgtm
ameukam
force-pushed
the
artifact-mgmt-sanbox
branch
from
b3f1582 to
5d3c27e
Compare
Ref: kubernetes#1758. Create a GCP project allowing II Coop folks to prototype cross-cloud artifact hosting infrastructure. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
ameukam
force-pushed
the
artifact-mgmt-sanbox
branch
from
5d3c27e to
d3ddbab
Compare
k8s-ci-robot
added
the
lgtm
spiffxp
approved these changes
Apr 23, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1758.
Create a GCP project allowing II Coop folks to prototype cross-cloud
artifact hosting infrastructure.
Signed-off-by: Arnaud Meukam ameukam@gmail.com