infra/gcp/prow: actually remove extraneous ssh-keys #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/prow
spiffxp
force-pushed
the
reset-e2e-project-ssh-keys
branch
2 times, most recently
from
0a0fef4 to
5d792b7
Compare
oh right, resetting ssh-keys means a different comparison needs to be used
spiffxp
force-pushed
the
reset-e2e-project-ssh-keys
branch
from
5d792b7 to
37e374a
Compare
k8s-ci-robot
added
size/M
spiffxp
changed the title
|
Running Twice, just to be sure the change takes. |
spiffxp
force-pushed
the
reset-e2e-project-ssh-keys
branch
from
37e374a to
9fb7975
Compare
|
Removed 37e374a |
k8s-ci-robot
added
size/S
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a [wip] commit to allow me to run
./infra/gcp/prow/ensure-e2e-projects.shwith a manual edit that skips everything per-project except ssh-key editing. Once that's done, I'll drop the [wip] commit from this PR.The code as previously written didn't actually drop ssh-keys. It does now, by using a different comparison when
K8S_INFRA_ENSURE_E2E_PROJECTS_RESETS_SSH_KEYSistrue. To make it more obvious what's happening when editing ssh keys in project metadata, simulate a diff of before/after changes.