Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote setcap image from gcr.io/k8s-staging-build-image -> k8s.gcr.io. #1644

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

vinayakankugoyal
Copy link
Contributor

Promoting the setcap image from k8s-staging-build-image to k8s.gcr.io

Image added in: kubernetes/release#1684
Prow build and push setup: kubernetes/test-infra#20857
Passing Prow build: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-setcap/1360441339472252928

Tested the image in a multistage docker build and verified the capabilities. (binary name has been redacted)

FROM gcr.io/k8s-staging-build-image/setcap:buster-v1.4.0
COPY BINARY /BINARY
RUN setcap cap_net_bind_service=+ep /BINARY

FROM ubuntu
COPY --from=0 /BINARY /usr/local/bin/BINARY
RUN apt-get update && apt-get -y --no-install-recommends install libcap2-bin

Built using buildx

docker buildx build -t setcap-test . 

Run the image and verify that the binary has the capabilities

docker run --rm setcap-test:latest getcap /BINARY
/BINARY = cap_net_bind_service+ep

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @vinayakankugoyal!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vinayakankugoyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2021
@vinayakankugoyal
Copy link
Contributor Author

/cc @BenTheElder

@vinayakankugoyal
Copy link
Contributor Author

Hmm.. according to https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/README.md#image-promoter this PR should have triggered pull-k8sio-cip but I don't see one. 🤔

@BenTheElder
Copy link
Member

BenTheElder commented Feb 13, 2021

/test
EDIT: this is a lazy way to find out what tests you can request

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-k8sio-cip
  • /test pull-k8sio-backup
  • /test pull-k8sio-groups-test

Use /test all to run the following jobs:

  • pull-k8sio-cip

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

ah: it isn't triggered because you need
/ok-to-test

if you're going to keep contributing in Kubernetes, you should consider applying for org membership with your work so you get that automatically and can participate in more aspects (e.g. becoming a reviewer)
https://github.com/kubernetes/community/blob/master/community-membership.md

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2021
@BenTheElder
Copy link
Member

(it would show up even if not triggered if it were Required to merge, which it probably ... should be? ....)

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit a95e96e into kubernetes:main Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants