-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote setcap image from gcr.io/k8s-staging-build-image -> k8s.gcr.io. #1644
Conversation
Welcome @vinayakankugoyal! |
Hi @vinayakankugoyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @BenTheElder |
e532e9c
to
d75f4cf
Compare
Hmm.. according to https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/README.md#image-promoter this PR should have triggered |
/test |
@BenTheElder: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ah: it isn't triggered because you need if you're going to keep contributing in Kubernetes, you should consider applying for org membership with your work so you get that automatically and can participate in more aspects (e.g. becoming a reviewer) |
(it would show up even if not triggered if it were |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, vinayakankugoyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Promoting the setcap image from k8s-staging-build-image to k8s.gcr.io
Image added in: kubernetes/release#1684
Prow build and push setup: kubernetes/test-infra#20857
Passing Prow build: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-release-push-image-setcap/1360441339472252928
Tested the image in a multistage docker build and verified the capabilities. (binary name has been redacted)
Built using buildx
Run the image and verify that the binary has the capabilities