Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Provision k8s-staging-experimental project #1594

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

justaugustus
Copy link
Member

To be used to stage experimental images, like support for new
architectures in an existing Tier 1 image.

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @dims @hasheddan @saschagrunert
cc: @kubernetes/release-engineering

Part of kubernetes/sig-release#1337.
Context (kubernetes/release#1880 (comment)):

1. We shouldn't add any new platforms to base images until there is clear path to at least `Tier 2` support in k/k. This would mean closing this PR and waiting until a functioning build of k/k can be demonstrated with this architecture.

The counter to my feeling is: "How can a platform elevate their tier without supporting artifacts like this?".

2. Adding support here allows for folks to more easily build k/k with that architecture to demonstrate its functionality as part of `Tier 3`. This would be accepting this PR and then having @houfangdong (or others) demonstrate ability to build k/k for this architecture, which would get them started on process to higher tiers.

If we are comfortable with taking on the new platform from a maintenance perspective here, I don't think it necessarily needs to be gated on the criteria for tiers in k/k. In fact, I think our aim should be for base images like this to be as broadly useful as possible to the extent that we have bandwidth to maintain.

So my concern here would another tier impacting our ability to support our current artifacts.
Example: @saschagrunert @cpanato saw image build errors recently with s390x, which cause our amd64 pushes to fail.

I think if we can establish a playground variant of sorts, then I'd be open to this:

Example:

* Tier 1: `debian-base:<tag>`

* Anything else: `debian-base-experimental-arch:<tag>`

Or even:

* Tier 1: `k8s.gcr.io/build-image/debian-base:<tag>`

* Anything else: `k8s.gcr.io/experimental-arch/debian-base:<tag>`

They would build using the same Dockerfile/Makefiles, but run independently and (maybe) push to different staging projects.

To be used to stage experimental images, like support for new
architectures in an existing Tier 1 image.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Jan 29, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@dims
Copy link
Member

dims commented Jan 29, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f9ca03f into kubernetes:master Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@dims
Copy link
Member

dims commented Jan 29, 2021

@justaugustus error running script!

davanum@cloudshell:~/k8s.io$ infra/gcp/ensure-staging-storage.sh experimental
Configuring staging: experimental
  Ensuring project exists: k8s-staging-experimental
  Create in progress for [https://cloudresourcemanager.googleapis.com/v1/projects/k8s-staging-experimental].
  Waiting for [operations/cp.5129442009212321338] to finish...
  ..done.
  billingAccountName: billingAccounts/018801-93540E-22A20E
  billingEnabled: true
  name: projects/k8s-staging-experimental/billingInfo
  projectId: k8s-staging-experimental
  Empowering k8s-infra-staging-experimental@kubernetes.io as project viewers
  ERROR: Policy modification failed. For a binding with condition, run "gcloud alpha iam policies lint-condition" to identify issues in condition.
  ERROR: (gcloud.projects.add-iam-policy-binding) INVALID_ARGUMENT: Group k8s-infra-staging-experimental@kubernetes.io does not exist.

@dims
Copy link
Member

dims commented Jan 29, 2021

This is ready now!

@justaugustus
Copy link
Member Author

Thanks Dims!

@dims dims mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants