-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPA examples on pathType restrictions #9992
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do you need to add a example for "should allow" for pathType "Prefix". Or one example for "should allow" is enough. I don't know so asking. |
I don't think so, the idea here is just to teach people how they can use OPA to block a specific pathType. We have a lot of cases, like blocking characters, allowing pathType if an annotation exists, etc and I don't want to cover all of them, just let them know they can use OPA to protect the requests |
Now I need to check if Kyverno use OPA at all. Someone may ask. |
We dont need to cover all cases, this is an example. We need people to be aware they need to apply policies :) |
ok :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
But I think we should add some text description, like the description in this PR.
Users can have a clearer understanding of the applicable scenarios of this example
1035322
to
865b793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
allows any characters, as it may contain regexes, variables and other features that may be specific of the Ingress | ||
Controller being used. | ||
|
||
This means that the Ingress Admins (the persona who deployed the Ingress Controller) should trust the users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the Ingress Admins (the persona who deployed the Ingress Controller) should trust the users | |
This means that the Ingress Admins (the person who deployed the Ingress Controller) should trust the users |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
With the upcoming restriction on pathType and usages, it is good to have an example on restrictions using OPA