Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for tags with custom values #11686

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Add tests for tags with custom values #11686

merged 2 commits into from
Jul 26, 2024

Conversation

MrErlison
Copy link
Member

What this PR does / why we need it:

Implement tests to verify that tags can handle custom values correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

/cc @rikatz

@k8s-ci-robot k8s-ci-robot requested a review from rikatz July 26, 2024 18:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
@rikatz rikatz self-assigned this Jul 26, 2024
@rikatz
Copy link
Contributor

rikatz commented Jul 26, 2024 •
edited
Loading

/triage accepted
/lgtm
/approve
If possible let's rebase over feature branch, otherwise lgtm. I will be bypassing tests at this point as we need to implement the "brotli" parser

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
rikatz
rikatz reviewed Jul 26, 2024
View reviewed changes
internal/ingress/controller/template/crossplane/crossplane_test.go
}
tpl := crossplane.NewTemplate()

t.Run("it should be able to marshall and unmarshall the default configuration", func(t *testing.T) {
tplConfig.Cfg.DefaultSSLCertificate = defaultCertificate
tplConfig.Cfg.EnableBrotli = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably should be moved to the specifics configurations test below, but we can do on a follow up

@rikatz
Copy link
Contributor

rikatz commented Jul 26, 2024

/lgtm
overriding merge due to brotli directives

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrErlison, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz rikatz merged commit ebd2917 into kubernetes:feature-go-crossplane Jul 26, 2024
43 of 45 checks passed
rikatz pushed a commit that referenced this pull request Sep 10, 2024
@MrErlison @rikatz
Add tests for tags with custom values (#11686)
37ff5ce 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit that referenced this pull request Sep 15, 2024
@MrErlison @rikatz
Add tests for tags with custom values (#11686)
3601d80 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Sep 29, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
ac2a43e 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit that referenced this pull request Sep 29, 2024
@MrErlison @rikatz
Add tests for tags with custom values (#11686)
4722741 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit that referenced this pull request Oct 3, 2024
@MrErlison @rikatz
Add tests for tags with custom values (#11686)
d94654e 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Oct 3, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
d6c3584 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Oct 28, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
f72cc8d 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 5, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
a759ec7 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 11, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
c22d05f 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 13, 2024
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
8f1c772 
* Add tests for tags with custom values

* Fix typo in comments
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Jan 12, 2025
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
69a3a4d 
* Add tests for tags with custom values

* Fix typo in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz left review comments

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrErlison @rikatz @k8s-ci-robot