Skip to content

KEP-4205: Graduate Expose PSI Metrics to GA #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP-4205: Graduate Expose PSI Metrics to GA #5605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5248b2
updating doc to graduate psi metrics from beta to ga
mariafromano-25 Oct 2, 2025
243b641
updated GA requirements after oct 7 signode meeting
mariafromano-25 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-node/4205.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ alpha:
approver: "@johnbelamaric"
beta:
approver: "@johnbelamaric"
stable:
approver: "@johnbelamaric"
8 changes: 5 additions & 3 deletions keps/sig-node/4205-psi-metric/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,10 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
- PSI metrics collection doesn't introduce excessive CPU or memory usage increase in the kubelet

#### GA
- Gather evidence of real world usage.
- No major issue reported.
- Quantify the cAdvisor and kubelet-level overhead of PSI metric collection, especially where PSI is disabled at the kernel level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also ensure we cover stress testing scenario. We may need to expand on top of the previous performance benchmarking

- Validate with SIG Node that collection overhead is acceptable for general use cases, or include opt-out knobs.
- Gather evidence of real-world usage from beta users.
- No major issues reported.

#### Deprecation

Expand Down Expand Up @@ -375,7 +377,7 @@ feature.

NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
-->
Yes
Yes, but starting in v1.35 where this feature graduates to GA, the KubeletPSI feature gate will be locked to true and will no longer be disable-able.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/1.35/1.36


###### What happens if we reenable the feature if it was previously rolled back?
No PSI metrics will be available in kubelet Summary API nor Prometheus metrics if the
Expand Down
7 changes: 4 additions & 3 deletions keps/sig-node/4205-psi-metric/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,18 @@ see-also: []
replaces: []

# The target maturity stage in the current dev cycle for this KEP.
stage: beta
stage: stable

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.34"
latest-milestone: "v1.35"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.33"
beta: "v1.34"
stable: "v1.36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should leave the milestone unchanged. We can update it during the 1.36 cycle. When we update we should confirm that all GA criteria are met.

Either way we will need to update the latest-milestone: "v1.35" line when 1.36 comes.


# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
Expand All @@ -41,7 +42,7 @@ feature-gates:
components:
- kubelet

disable-supported: true
disable-supported: false

# The following PRR answers are required at beta release
metrics:
Expand Down