Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2644: promote HonorPVReclaimPolicy to GA #5035

Merged
merged 2 commits into from
Feb 10, 2025
Merged

KEP-2644: promote HonorPVReclaimPolicy to GA #5035

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54f764
promote HonorPVReclaimPolicy to GA
carlory Jan 13, 2025
82b916f
update KEP with the latest template
carlory Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions keps/prod-readiness/sig-storage/2644.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ kep-number: 2644
alpha:
approver: "@ehashman"
beta:
approver: "@ehashman"
stable:
approver: "@ehashman"
3 changes: 2 additions & 1 deletion keps/sig-storage/2644-honor-pv-reclaim-policy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ The finalizer `kubernetes.io/pv-controller` will not be added on statically prov
#### E2E tests
An e2e test to exercise deletion of PV prior to deletion of PVC for a `Bound` PV-PVC pair.

- `test/e2e/storage/csimock/csi_honor_pv_reclaim_policy.go`: [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html?sig=scheduling,storage&test=honor%20pv%20reclaim%20policy)
- [test/e2e/storage/csimock/csi_honor_pv_reclaim_policy.go](https://github.com/kubernetes/kubernetes/blob/2334b8469e1983c525c0c6382125710093a25883/test/e2e/storage/csimock/csi_honor_pv_reclaim_policy.go): [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html?sig=scheduling,storage&test=honor%20pv%20reclaim%20policy), [k8s-test-grid](https://testgrid.k8s.io/sig-storage-kubernetes#kind-storage-alpha-beta-features&include-filter-by-regex=CSI%20Mock%20honor%20pv%20reclaim%20policy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover, the current e2e seem to ONLY verify the order delete PV and then delete PVC, based on my understanding this document we should have tests ensuring that no matter what the order of removing PV and PVC is we should receive appropriate reclaim handling. So I'd expect tests covering both orders, iow. PV then PVC, and PVC then PV.

This still holds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will submit a PR to add the new tests to k/k.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update it once kubernetes/kubernetes#129997 is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


### Graduation Criteria

Expand Down Expand Up @@ -390,6 +390,7 @@ No.

1.26: Alpha
1.31: Add e2e tests for the feature and promote to Beta.
1.33: Promote to GA.

## Drawbacks
None. The current behavior could be considered as a drawback, the KEP presents the fix to the drawback. The current
Expand Down
5 changes: 3 additions & 2 deletions keps/sig-storage/2644-honor-pv-reclaim-policy/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ approvers:
see-also:
replaces:

stage: beta
stage: stable

latest-milestone: "v1.31"
latest-milestone: "v1.33"

milestone:
alpha: "v1.23"
beta: "v1.31"
stable: "v1.33"

feature-gates:
- name: HonorPVReclaimPolicy
Expand Down