-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate release artifact signing to beta #3323
Conversation
2960d72
to
8aa47ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would do a small change here. The change suggested below is just for defining what we consider to be beta: We can sign both files and images.
My thinking now is that for GA we should enlist a concrete set of artifacts we'd like to sign and graduate the KEP when done (ie attestations from the promoter, stage provenance, release provenance, etc).
8aa47ff
to
d1f4fc9
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
d1f4fc9
to
14ac39d
Compare
@kubernetes/sig-release PTAL |
Thanks @saschagrunert ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/assign @johnbelamaric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/approve
/lgtm
@kubernetes/prod-readiness-reviewers PTAL |
Sorry, this isn't on the KEP enhancements sheets so I did not see it until now. Just luck that I saw it in fact... /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, johnbelamaric, justaugustus, puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating the release artifact signing KEP to beta.
Refers to #3031
cc @kubernetes/sig-release-leads @kubernetes/sig-release @kubernetes/release-engineering