Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1472: storage capacity tracking: GA #3229

Merged
merged 3 commits into from
Mar 2, 2022
Merged

KEP-1472: storage capacity tracking: GA #3229

merged 3 commits into from
Mar 2, 2022

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 24, 2022

  • Other comments: exception will be needed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Feb 24, 2022
@pohly
Copy link
Contributor Author

pohly commented Feb 24, 2022

/assign @wojtek-t

For PRR review.

/assign @msau42

For SIG review.

pohly
pohly commented Feb 24, 2022
View reviewed changes
keps/sig-storage/1472-storage-capacity-tracking/README.md
@@ -806,7 +806,7 @@ checks for events that describe the problem.
- 5 installs
- More rigorous forms of testing e.g., downgrade tests and scalability tests
- Allowing time for feedback
- Integration with [Cluster Autoscaler](https://github.com/kubernetes/autoscaler)
- Design for support in [Cluster Autoscaler](https://github.com/kubernetes/autoscaler)
Copy link
Contributor Author

@pohly pohly Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slightly relaxed criteria: kubernetes/autoscaler#3887 shows that the current in-tree API is sufficient to enable autoscaling, the PR just hasn't been merged yet because SIG Autoscaling wanted more time to investigate how this can be made simpler for users.

The recommendation from the SIG Autoscaling meeting on 2022-02-21 was to not wait for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to this PR in the KEP to show this is in progress?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this section with a summary of the design?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @x13n @MaciekPytel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. It basically works exactly as alluded in that section: labeling of generated nodes must be modified to distinguish them from real ones and then manually created CSIStorageCapacity objects provide the information about those future nodes.

wojtek-t
wojtek-t reviewed Feb 28, 2022
View reviewed changes
keps/sig-storage/1472-storage-capacity-tracking/README.md Show resolved Hide resolved
keps/sig-storage/1472-storage-capacity-tracking/README.md Outdated
@@ -934,7 +940,7 @@ consumption, increased latency), specifically

* **Were upgrade and rollback tested? Was upgrade->downgrade->upgrade path tested?**

Not yet, but will be done manually before transition to beta.
This was done manually before transition to beta.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any findings? Can you describe the environment in which it was run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No surprises. I used a kubeadm-based cluster in VMs. I've extended the text.

keps/sig-storage/1472-storage-capacity-tracking/kep.yaml
# The following PRR answers are required at beta release
#metrics:
# - my_feature_metric
metrics:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

wojtek-t
wojtek-t reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more comments - once addressed this LGTM

keps/sig-storage/1472-storage-capacity-tracking/README.md Show resolved Hide resolved
@wojtek-t
Copy link
Member

wojtek-t commented Mar 1, 2022

This LGTM - I will wait with approving until you have SIG approval, please ping me when this happens.

@msau42
Copy link
Member

msau42 commented Mar 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2022
This was referenced Mar 1, 2022
Open
Closed
@pohly
Copy link
Contributor Author

pohly commented Mar 1, 2022

/retest

@wojtek-t
Copy link
Member

wojtek-t commented Mar 2, 2022

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit b1ca599 into kubernetes:master Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 2, 2022
@alculquicondor
Copy link
Member

alculquicondor commented Mar 3, 2022 •
edited
Loading

For SIG review.

In retrospective, you should ask the participating SIGs for each graduation, too. But in this case in particular, I would also have like to have the review of SIG autoscaling.

@pohly
Copy link
Contributor Author

pohly commented Mar 3, 2022

In retrospective, you should ask the participating SIGs for each graduation, too.

Sorry, that wasn't intentional.

But in this case in particular, I would also have like to have the review of SIG autoscaling.

I explicitly asked them before even proposing the graduation. The feedback from them was to not delay on behalf of autoscaler (see February 21, 2022 meeting notes).

@pohly pohly mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@wojtek-t wojtek-t

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @wojtek-t @msau42 @k8s-ci-robot @alculquicondor @xing-yang