Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keps/sig-testing: propose v1.23 graduations #2871

Merged
merged 2 commits into from
Sep 8, 2021
Merged

keps/sig-testing: propose v1.23 graduations #2871

merged 2 commits into from
Sep 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 17, 2021

Broken out of #2867

KEPs this proposes for graduation in v1.23:

/hold
For #2867 to merge

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 17, 2021
@spiffxp spiffxp force-pushed the v1.23-sig-testing-keps branch from 3f9af2f to f03a4fc Compare August 17, 2021 17:33
@spiffxp spiffxp mentioned this pull request Aug 17, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

LGTM from @amwat here: #2867 (review)
/cc @BenTheElder
for LGTM on 2420

This was referenced Aug 17, 2021
Open
Closed
@BenTheElder
Copy link
Member

#2420 (comment)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@spiffxp spiffxp force-pushed the v1.23-sig-testing-keps branch from f03a4fc to 32c1ece Compare August 17, 2021 20:47
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

/hold cancel
#2867 merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2021

/assign @johnbelamaric
for PRR

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@BenTheElder
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit ec7f8fc into kubernetes:master Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
@spiffxp spiffxp deleted the v1.23-sig-testing-keps branch September 8, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun Awaiting requested review from palnabarun

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@BenTheElder BenTheElder

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @BenTheElder @johnbelamaric @k8s-ci-robot