Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicluster DNS #2577

Merged
merged 32 commits into from
Mar 23, 2022
Merged

Multicluster DNS #2577

merged 32 commits into from
Mar 23, 2022

Conversation

lauralorenz
Copy link
Contributor

@lauralorenz lauralorenz commented Mar 18, 2021 •
edited
Loading

Moved in content from community doc proposals http://bit.ly/k8s-multicluster-dns and http://bit.ly/k8s-multicluster-dns-slides.

Notable changes here:

  • PTR records caveated for implementations that already have PTR records from cluster-local DNS i.e. "dummy" Service based implementations of MCS API
  • <clusterid>.<svc>.<ns>.svc.<clustersetzone>. explicitly not allowed in the specification for either ClusterSetIP or Multicluster Headless Services with rationale explained in the KEP
  • Left in SRV records for now

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @lauralorenz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2021
@lauralorenz lauralorenz marked this pull request as ready for review March 30, 2021 15:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2021
@lauralorenz
Copy link
Contributor Author

After talking to SIG-Network on 4/1 and confirming with SIG-Multicluster 4/13, we are keeping SRV records since use cases for it exist (VOIP, Active Directory, and etcd cluster bootstrapping being the concrete ones). I've added info about that and done a copyediting/formatting pass so I'm looking for official lgtms and approvals now. cc MCS API reviewer representing DNS @johnbelamaric and MCS API approvers @pmorie and @thockin

@pmorie
Copy link
Member

pmorie commented Apr 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2021
@lauralorenz
Copy link
Contributor Author

/retest

@lauralorenz
Copy link
Contributor Author

/test pull-enhancements-verify

@lauralorenz
Copy link
Contributor Author

/test pull-enhancements-verify

@lauralorenz lauralorenz requested a review from thockin February 23, 2022 03:02
@lauralorenz
Copy link
Contributor Author

lauralorenz commented Feb 23, 2022 •
edited
Loading

Howdy @thockin, I finally incorporated all the SIG-Network feedback and besides nits, change highlights include

  1. Remove requirement for PTR records entirely and include rationale for why in e7dd34d (SIG-MC discussed this in Aug '21 and I discussed this with @prameshj offline back then too)
  2. Require only a subset of IPs be programmed for headless DNS. I specifically use the word "subset" instead of your recommended terminology "strict subset" (as it may be "all", implementation dependent) and require that the same IPs returned by the aggregate DNS form (<service>.<ns>.svc.<clusterset-zone>. IN A <endpoint-ip>s) should be programmed in their pod IP form (<hostname>.<clusterid>.<service>.<ns>.svc.<clusterset-zone>. <ttl> IN A <endpoint-ip>) AND ON TOP OF THAT if there's IPv6 and AAAA records are programmed they should use the same subset too. Open to feedback on all those points. This is split between commits 5419c15 and 693d15d.
  3. Reserve disallowed DNS forms for future use and say the MUST NOT (not "should not") exist for now. 8c25fa3 and 516afb9

cc @prameshj and FYI @johnbelamaric I'm coming for your LGTM again next

thockin
thockin reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits!

keps/sig-multicluster/1645-multi-cluster-services-api/README.md Outdated Show resolved Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md Outdated Show resolved Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md Outdated Show resolved Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md Outdated Show resolved Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/specification.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2022
@lauralorenz lauralorenz requested a review from thockin February 25, 2022 21:57
@thockin thockin added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 8, 2022
@thockin
Copy link
Member

thockin commented Mar 8, 2022

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@lauralorenz
Copy link
Contributor Author

Howdy @johnbelamaric your LGTM is needed again as it fell off when I made changes SIG-Network asked for.

Changelog since you last LGTMd is

  • everything in this comment
  • awareness that we need to align single-cluster DNS spec and this spec on the new definition of "ready" at some point (see comment).

THANK YOU!

johnbelamaric
johnbelamaric approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, lauralorenz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit cdb9ffc into kubernetes:master Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 23, 2022
ahmedtd pushed a commit to ahmedtd/enhancements that referenced this pull request Jun 8, 2022
@lauralorenz @ahmedtd
Multicluster DNS (kubernetes#2577)
3df39e0 
* adding skeleton for PR

* move over everything except PTR records

* Adding in PTR records

* move <clustersetzone> being non configurable info to definition section, update links

* update links again, more specific

* add link to clusterid

* Clean up prose flow a bit, and add some rationale on SRV and PTR records in the readme

* in overview explicitly reference dummy service implementation as a reason to not need PTR records at multicluster DNS level

* Copyediting and formatting

* set initial schema version

* getting a little picky about sticky caps on clusterset

* fix toc

* also add toc for specification.md

* adding note on dual-stack

* Change examples to use more readable clusterIDs and add in to headless SRV records for clarity

* Be more clear about what hostname means in this spec file directly

* allow flexibility on headless service DNS reporting a subset of pod IPs

* clarify ClusterIPs are not necessarily accessible clusterset wide

* fix zone->clustersetzone

* reserve disallowed DNS forms for future use

* for disallowed DNS records, they MUST NOT not just should not

* use better prose for how ClusterSetIP DNS clusterips work

* clustersetzone->clusterset-zone

* S A V A G E removed PTR recordsgit status k bye

* fix toc

* fix toc again

* add subset language to actual specification.md for headless service DNS

* wording nits and follow RFC 1123 my own self

* some formatting and clarify prose on subset used for headless A/AAAA records in dual stack case

* rewrap specification.md

* rewrap MCS API doc, praying the toc is healthy

* toc did not like getting rewrapped yall
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prameshj prameshj prameshj left review comments

@sstoner sstoner sstoner left review comments

@mangelajo mangelajo mangelajo left review comments

@johnbelamaric johnbelamaric johnbelamaric approved these changes

@annajung annajung Awaiting requested review from annajung

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@thockin thockin Awaiting requested review from thockin

Assignees

@thockin thockin

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
10 participants
@lauralorenz @k8s-ci-robot @pmorie @mangelajo @johnbelamaric @AaronLinOops @JeremyOT @thockin @sstoner @prameshj