Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from old kep to new template - kep-number: 2330 #2460

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Migrating from old kep to new template - kep-number: 2330 #2460

merged 1 commit into from
Feb 9, 2021

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 8, 2021

all the sig-api-machinery keps migrated to new template

renaming the directory name

clean pick of #2331

Conflict was https://github.com/kubernetes/enhancements/pull/2407/files#diff-12e705ee896b046dbff36eded067309015c895dab52bf4be5001609d8fe439caL46

@shekhar-rajak @deads2k
Migrating from old kep to new template - kep-number: 2330
76f2798 
all the sig-api-machinery keps migrated to new template

renaming the directory name
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp February 8, 2021 19:56
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 8, 2021
@wojtek-t
Copy link
Member

wojtek-t commented Feb 9, 2021

Since you approved the original one, I will simply lgtm this one :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@wojtek-t wojtek-t mentioned this pull request Feb 9, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit ad93a2a into kubernetes:master Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 9, 2021
mikemorris added a commit to mikemorris/kube-storage-version-migrator that referenced this pull request Aug 1, 2022
@mikemorris
README: update links to related KEPs
b43236d 
Refs kubernetes/enhancements#2460
@mikemorris mikemorris mentioned this pull request Aug 1, 2022
Closed
@bells17 bells17 mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedebongio fedebongio Awaiting requested review from fedebongio

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @k8s-ci-robot @wojtek-t @shekhar-rajak