Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CLI section in release note #222

Merged
merged 1 commit into from
Mar 23, 2017
Merged

update CLI section in release note #222

merged 1 commit into from
Mar 23, 2017

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Mar 22, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017
@mengqiy
Copy link
Member Author

mengqiy commented Mar 22, 2017

/assign @pwittrock

@calebamiles
Copy link
Contributor

@pwittrock, please take a look. Thanks!

@@ -53,8 +53,49 @@
### New Features
- Add new command "kubectl set selector" ([#38966](https://github.com/kubernetes/kubernetes/pull/38966), [@kargakis](https://github.com/kargakis))
- Add kubectl create poddisruptionbudget command ([#36646](https://github.com/kubernetes/kubernetes/pull/36646), [@kargakis](https://github.com/kargakis))
- Add new DaemonSet status fields to kubectl printer and describer. ([#42843](https://github.com/kubernetes/kubernetes/pull/42843), [@janetkuo](https://github.com/janetkuo))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no new features for SIG-CLI in 1.6 release per the features tracking spreadsheet.

Please, move the notes from "new features" section to "notable changes" or "breaking changes" sections.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it makes sense to try and maintain a strict mapping between "new features" and "features appearing in kubernetes/features, @idvoretskyi. I think we should give broad deference to the SIG contributors and we can move any thing around ourselves if we need to make edits on their organization

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebamiles it makes sense regarding the "features" meaning and process handling. If there is a feature for 1.6, it has to be reflected in the features repo under 1.6 milestone; otherwise, we have to define it as a "notable" or a "breaking" change.
It's not a problem for me to make edits afterward, but it would be great if people will be aware of it.

@mengqiy
Copy link
Member Author

mengqiy commented Mar 23, 2017

@pwittrock Regrouped and rewording some of them. PTAL and feel free to rewording them.

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM is terms of formatting.

@idvoretskyi
Copy link
Member

@ymqytw thank you! @pwittrock please, verify the content and we are done with this item.

@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2017
@calebamiles calebamiles merged commit 3cb2cd9 into kubernetes:release-notes-draft-1.6 Mar 23, 2017
@mengqiy mengqiy deleted the update_release_note branch March 23, 2017 22:50
justaugustus pushed a commit to justaugustus/enhancements that referenced this pull request Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants