-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CLI section in release note #222
update CLI section in release note #222
Conversation
/assign @pwittrock |
@pwittrock, please take a look. Thanks! |
release-1.6/release-notes-draft.md
Outdated
@@ -53,8 +53,49 @@ | |||
### New Features | |||
- Add new command "kubectl set selector" ([#38966](https://github.com/kubernetes/kubernetes/pull/38966), [@kargakis](https://github.com/kargakis)) | |||
- Add kubectl create poddisruptionbudget command ([#36646](https://github.com/kubernetes/kubernetes/pull/36646), [@kargakis](https://github.com/kargakis)) | |||
- Add new DaemonSet status fields to kubectl printer and describer. ([#42843](https://github.com/kubernetes/kubernetes/pull/42843), [@janetkuo](https://github.com/janetkuo)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no new features for SIG-CLI in 1.6 release per the features tracking spreadsheet.
Please, move the notes from "new features" section to "notable changes" or "breaking changes" sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it makes sense to try and maintain a strict mapping between "new features" and "features appearing in kubernetes/features
, @idvoretskyi. I think we should give broad deference to the SIG contributors and we can move any thing around ourselves if we need to make edits on their organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calebamiles it makes sense regarding the "features" meaning and process handling. If there is a feature for 1.6, it has to be reflected in the features repo under 1.6 milestone; otherwise, we have to define it as a "notable" or a "breaking" change.
It's not a problem for me to make edits afterward, but it would be great if people will be aware of it.
@pwittrock Regrouped and rewording some of them. PTAL and feel free to rewording them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM is terms of formatting.
@ymqytw thank you! @pwittrock please, verify the content and we are done with this item. |
/lgtm |
Modify spelling mistake
No description provided.