kep/dry-run: Add required release sections #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
lavalamp
reviewed
Jan 30, 2020
| `--dry-run=server`. The boolean form will be preserved during the deprecation | ||
| before being removed. It's been very clear from usage that the current flag is | ||
| too hard to find and not obvious enough, even though it often matches what | ||
| people are expecting. More details about this startegy are given in the #kubectl |
There was a problem hiding this comment.
Suggested change
| people are expecting. More details about this startegy are given in the #kubectl | |
| people are expecting. More details about this strategy are given in the #kubectl |
There was a problem hiding this comment.
Yeah, the bot told me too :-)
There was a problem hiding this comment.
A "startegy" should clearly mean "a plan to begin something".
apelisse
force-pushed
the
dry-run-kep-fix
branch
from
f32bfa3 to
16a9506
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing sections. The changes for GA had already been discussed and approved as part of #1399