-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kepify: New command to generate KEP json for Netlify #1467
kepify: New command to generate KEP json for Netlify #1467
Conversation
here's a crack at what we talked about on friday. running the command generates a json file which hopefully can be massaged to work with netlify. PTAL Here's what it looks like https://gist.github.com/dims/97ca19d97d74c5ec697f7d01c5dc1247 |
c1b38ba
to
166754f
Compare
`go run cmd/kepify/main.go --dir keps --output out.json`
166754f
to
502b4a7
Compare
Thank you for working on this 🙏 I just have a couple of comments. |
updated generated json in https://gist.github.com/dims/97ca19d97d74c5ec697f7d01c5dc1247 |
/assign @justaugustus @jdumars @calebamiles Folks, let's please merge and iterate, this is just the first cut. Hoping @saschagrunert @jeefy and others can help tweak things as we try this with netlify |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @justaugustus |
@dims a first implementation proposal can be found here: kubernetes-sigs/release-notes#140 We probably want to setup a new k-sigs project for this. |
@saschagrunert new repo sounds good! please request one at https://github.com/kubernetes/org/issues |
go run cmd/kepify/main.go --dir keps --output out.json