Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kepify: New command to generate KEP json for Netlify #1467

Merged

Conversation

dims
Copy link
Member

@dims dims commented Jan 18, 2020

go run cmd/kepify/main.go --dir keps --output out.json

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/pm labels Jan 18, 2020
@dims
Copy link
Member Author

dims commented Jan 18, 2020

cc @saschagrunert @jeefy

here's a crack at what we talked about on friday. running the command generates a json file which hopefully can be massaged to work with netlify. PTAL

Here's what it looks like https://gist.github.com/dims/97ca19d97d74c5ec697f7d01c5dc1247

@dims dims force-pushed the kepify-to-generate-json-for-netlify branch 4 times, most recently from c1b38ba to 166754f Compare January 19, 2020 21:34
`go run cmd/kepify/main.go --dir keps --output out.json`
@dims dims force-pushed the kepify-to-generate-json-for-netlify branch from 166754f to 502b4a7 Compare January 19, 2020 21:36
cmd/kepify/main.go Outdated Show resolved Hide resolved
cmd/kepify/main.go Show resolved Hide resolved
cmd/kepify/main.go Show resolved Hide resolved
cmd/kepify/main.go Outdated Show resolved Hide resolved
cmd/kepify/main.go Show resolved Hide resolved
cmd/kepify/main.go Outdated Show resolved Hide resolved
cmd/kepify/main.go Show resolved Hide resolved
@saschagrunert
Copy link
Member

Thank you for working on this 🙏 I just have a couple of comments.

@dims dims changed the title [WIP] new command to generate json for netlify new command to generate json for netlify Jan 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2020
@dims
Copy link
Member Author

dims commented Jan 20, 2020

updated generated json in https://gist.github.com/dims/97ca19d97d74c5ec697f7d01c5dc1247

@dims
Copy link
Member Author

dims commented Jan 20, 2020

/assign @justaugustus @jdumars @calebamiles

Folks, let's please merge and iterate, this is just the first cut. Hoping @saschagrunert @jeefy and others can help tweak things as we try this with netlify

@justaugustus
Copy link
Member

/lgtm
/approve
/kind feature

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@justaugustus justaugustus changed the title new command to generate json for netlify kepify: New command to generate KEP json for Netlify Jan 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9ee1336 into kubernetes:master Jan 20, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: keps-beta, v1.18 Jan 20, 2020
@dims
Copy link
Member Author

dims commented Jan 20, 2020

thanks @justaugustus

@saschagrunert
Copy link
Member

@dims a first implementation proposal can be found here: kubernetes-sigs/release-notes#140

We probably want to setup a new k-sigs project for this.

@dims
Copy link
Member Author

dims commented Jan 24, 2020

@saschagrunert new repo sounds good! please request one at https://github.com/kubernetes/org/issues

@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants