Skip to content

Commit

Permalink
Merge pull request #3760 from dgrisonnet/383-update-scope
Browse files Browse the repository at this point in the history
Update KEP-383 graduation criterias
  • Loading branch information
k8s-ci-robot authored Jan 19, 2023
2 parents 545228c + 4301eea commit fe68421
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
23 changes: 3 additions & 20 deletions keps/sig-instrumentation/383-new-event-api-ga-graduation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
- [Deprecated Fields](#deprecated-fields)
- [Beta to GA Graduation](#beta-to-ga-graduation)
- [Load Test](#load-test)
- [Components Migration](#components-migration)
- [Considerations](#considerations)
- [Performance Impact](#performance-impact)
- [Backward Compatibility](#backward-compatibility)
Expand Down Expand Up @@ -74,7 +73,7 @@ The KEP aims at fixing few issues in the current way Events are structured and i

Most sections and design details are copied from the original design doc: [Make Kubernetes Events Useful and Safe](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/events-redesign.md).

The new Event API has been promoted from v1beta1 to v1 in 1.19 and currently only scheduler was migrated to use it. This KEP proposes to graduate the new Event API by migrating all the remaining Kubernetes components to use the new Event API.
The new Event API has been promoted from v1beta1 to v1 in 1.19 and currently only scheduler was migrated to use it.

## Motivation

Expand Down Expand Up @@ -370,7 +369,7 @@ Scalability and Performance:

### Graduation Criteria

The new Event API is in v1 right now and scheduler has been migrated to use new API. The plan is to do a load test and migrate all the remaining components.
The new Event API is in v1 right now and scheduler has been migrated to use new API. The plan is to do a load test before migrating all the remaining components.

#### Deprecated Fields

Expand All @@ -383,27 +382,11 @@ This section lists the deprecated Event API fields that should be removed before

- Remove deprecated fields listed above
- Gather data from performance and scalability tests
- Remove all in-tree use of the core/v1.Event API in favour of events.k8s.io/v1

#### Load Test

The idea is to use [ClusterLoader](https://github.com/kubernetes/perf-tests/tree/master/clusterloader2) testing framework to do a load test to make sure events generated can be handled by etcd and there's no big performance reduction.

#### Components Migration

The list of components that need to be migrated is shown as follows:

- kubelet
- cloud-controller-manager
- kube-controller-manager
- leader election
- node problem detector
- gce ingress controller
- event exporter

(Note: there are more out-of-tree components that need to be migrated)


## Considerations

### Performance Impact
Expand Down Expand Up @@ -745,4 +728,4 @@ We considered making easier for automated systems to use Events by enforcing "ac

### Pivoting Towards Making Events More Helpful for Cluster Operator During Debugging

We considered exposing more data that cluster operator would need to use Events for debugging, e.g. making ReportingController more central to the semantics of Event and adding some way to easily grep though the logs of appropriate component when looking for context of a given Event. This idea was dropped because Events are supposed to give application developer who's running his application on the cluster a rough understanding what was happening with his app.
We considered exposing more data that cluster operator would need to use Events for debugging, e.g. making ReportingController more central to the semantics of Event and adding some way to easily grep though the logs of appropriate component when looking for context of a given Event. This idea was dropped because Events are supposed to give application developer who's running his application on the cluster a rough understanding what was happening with his app.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ approvers:
- "@brancz"
creation-date: 2019-01-31
last-updated: 2021-02-03
status: implementable
status: implemented
see-also:
replaces:
stage: stable
Expand Down

0 comments on commit fe68421

Please sign in to comment.