Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translation #5024

Merged
merged 1 commit into from
Mar 23, 2020
Merged

update translation #5024

merged 1 commit into from
Mar 23, 2020

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Mar 23, 2020

Ref: #4259

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/zh Updates or issues for Chinese translations. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@hwdef
Copy link
Member Author

hwdef commented Mar 23, 2020

/assign @tanjunchen @chenrui333

@hwdef
Copy link
Member Author

hwdef commented Mar 23, 2020

/hold
for zh-hant.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2020
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #5024 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5024      +/-   ##
==========================================
- Coverage   45.42%   45.39%   -0.03%     
==========================================
  Files         214      214              
  Lines       10078    10078              
  Branches      100      100              
==========================================
- Hits         4578     4575       -3     
- Misses       5232     5236       +4     
+ Partials      268      267       -1
Impacted Files Coverage Δ
src/app/backend/sync/secret.go 70.29% <0%> (-2.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e26084...6129bf3. Read the comment docs.

@zehuaiWANG
Copy link
Contributor

zehuaiWANG commented Mar 23, 2020

/lgtm
thanks~ @hwdef

@tanjunchen
Copy link
Member

tanjunchen commented Mar 23, 2020

/lgtm
@hwdef Thanks for your contribution

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, tanjunchen, zehuaiWANG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hwdef
Copy link
Member Author

hwdef commented Mar 23, 2020

@tanjunchen @zehuaiWANG
Thanks for your review.

@hwdef
Copy link
Member Author

hwdef commented Mar 23, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7a09d4e into kubernetes:master Mar 23, 2020
@hwdef hwdef deleted the update-zh-trans2 branch March 23, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants