Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require secure cookie only for sensitive data #4888

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 7, 2020

Fixes #4887

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2020
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #4888 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4888      +/-   ##
=========================================
- Coverage   45.41%   45.4%   -0.02%     
=========================================
  Files         214     214              
  Lines        9986    9986              
  Branches       94      94              
=========================================
- Hits         4535    4534       -1     
- Misses       5186    5187       +1     
  Partials      265     265
Impacted Files Coverage Δ
.../frontend/common/services/global/authentication.ts 40.32% <ø> (ø) ⬆️
...p/backend/integration/metric/common/aggregation.go 89.09% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086f76c...8a18e03. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 62635aa into kubernetes:master Feb 7, 2020
@floreks floreks deleted the fix/samesite branch February 7, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.0.0-rc4 : Cannot login on localhost anymore
3 participants