Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: meet our contributors APAC Aus-Nz region #292

Merged
merged 3 commits into from
Mar 14, 2022
Merged

blog: meet our contributors APAC Aus-Nz region #292

merged 3 commits into from
Mar 14, 2022

Conversation

Debanitrkl
Copy link
Member

This PR adds the second blog post for APAC region(AUS-NZ), in the series of "Meet Our Contributors - APAC" blog series.

Reference issue: kubernetes/community#4469 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from jberkus and jeefy March 2, 2022 10:37
sftim
sftim reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits

@chris-short
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2022
@sftim
Copy link
Contributor

sftim commented Mar 11, 2022

@Debanitrkl is there a similar PR (to mirror this one) opened against k/website?

sftim
sftim suggested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set a publication date that's in the future, and aim to merge on that date.

content/en/blog/2022/meet-our-contributors-APAC-au-nz-region-02.md Outdated
---
layout: blog
title: "Meet Our Contributors - APAC (Aus-NZ region)"
date: 2022-03-02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date is now in the past

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Debanitrkl lemme know what date you want to publish this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the date

@Debanitrkl
Copy link
Member Author

@Debanitrkl is there a similar PR (to mirror this one) opened against k/website?

Not yet I was waiting for this PR to get merged and then get a PR up at k/website

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2022
@jberkus
Copy link
Contributor

jberkus commented Mar 14, 2022

Looks good.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chris-short, Debanitrkl, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0c2b06d into kubernetes:master Mar 14, 2022
@Debanitrkl
Copy link
Member Author

@Debanitrkl is there a similar PR (to mirror this one) opened against k/website?

@sftim kubernetes/website#32278 here's the PR in k/website could you please take a look

@sftim sftim mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@jberkus jberkus Awaiting requested review from jberkus

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@jberkus jberkus

@chris-short chris-short

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Debanitrkl @chris-short @sftim @jberkus @k8s-ci-robot