Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to configure Bazel for Python 2 #3738

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

praseodym
Copy link
Contributor

@praseodym praseodym commented May 26, 2019

This PR adds instructions to configure Bazel with Python 2. I removed the explicit reference to bazelbuild/rules_docker#454 because now that it has been fixed, make_deb.py is broken (bazelbuild/bazel#8443) and Python 3 still doesn't work.

I also turned all links in the paragraph into references, which makes the source a little more readable.

@k8s-ci-robot
Copy link
Contributor

Welcome @praseodym!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @praseodym. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2019
@k8s-ci-robot k8s-ci-robot added area/developer-guide Issues or PRs related to the developer guide sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 26, 2019
@praseodym
Copy link
Contributor Author

/assign @stevekuznetsov

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2019
@praseodym
Copy link
Contributor Author

@fejta @timothysc @stevekuznetsov could I get a lgtm (or some feedback) on this PR? Thanks!

`/usr/bin/env python` must be python2 in order for all the Bazel commands listed
below to succeed.
Instructions for installing Bazel can be found [here][bazel-install].
Note that Bazel currently does not work with Python 3, which means that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe in the accuracy of this statement. Why do you believe it?

If it is true, what issues should we track (please link to them) that will help us understand that this documentation is stale.

Copy link
Contributor Author

@praseodym praseodym Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazelbuild/bazel#8443 (referenced in the PR description too), which apparently has been fixed now. I’m not sure if something needs to be done to get that fix into Kubernetes too (how does the release tooling determine which Bazel version to use?).

Copy link

@clarketm clarketm Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel supports python3 via python toolchain by default since bazel 0.27.0. Here is a good FAQ as well as migration steps (bazelbuild/bazel#7899). I suggest either cherrypicking useful statements from that guide or linking to it directly.

--

Moreover, the default python_version for bazel was changed to python3 in 0.25.0 (bazelbuild/bazel#7359) and --python_path is deprecated as of 0.27.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've rewritten the paragraph and included a link to the FAQ as well.

@fejta
Copy link
Contributor

fejta commented Aug 5, 2019

/assign @clarketm
Can you review this? You're working on some py3 migration stuff

`/usr/bin/env python` must be python2 in order for all the Bazel commands listed
below to succeed.
Instructions for installing Bazel can be found [here][bazel-install].
Note that Bazel currently does not work with Python 3, which means that
Copy link

@clarketm clarketm Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel supports python3 via python toolchain by default since bazel 0.27.0. Here is a good FAQ as well as migration steps (bazelbuild/bazel#7899). I suggest either cherrypicking useful statements from that guide or linking to it directly.

--

Moreover, the default python_version for bazel was changed to python3 in 0.25.0 (bazelbuild/bazel#7359) and --python_path is deprecated as of 0.27.0

@praseodym praseodym force-pushed the bazel-python2 branch 2 times, most recently from aadc1e7 to a92a970 Compare August 6, 2019 20:08
@clarketm
Copy link

clarketm commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clarketm, fejta, praseodym

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e3b806 into kubernetes:master Aug 6, 2019
@praseodym praseodym deleted the bazel-python2 branch August 7, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants