-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify need for using py2 with Bazel #3241
Specify need for using py2 with Bazel #3241
Conversation
The default python on my system is python3. This caused me to run into bazelbuild/rules_docker#454 when running `bazel build //...`. Update the documentation to indicate that `/usr/bin/env python` must resolve to python2 in order for all of the Bazel commands included in the documentation to work. We can remove this comment after Bazel better supports using python3 as the default system python. It appears from bazelbuild/rules_docker#580 that the `rules_docker` folks hope to merge the fix in mid to late Q1 2019.
Hi @mattjmcnaughton. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @stevekuznetsov thanks :) |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, mattjmcnaughton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The default python on my system is python3. This caused me to run into
bazelbuild/rules_docker#454 when running
bazel build //...
. Update the documentation to indicate that/usr/bin/env python
must resolve to python2 in order for all of theBazel commands included in the documentation to work.
We can remove this comment after Bazel better supports using python3 as
the default system python. It appears from
bazelbuild/rules_docker#580 that the
rules_docker
folks hope to merge the fix in mid to late Q1 2019.