Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump govmomi to 0.30.6 #738

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Bump govmomi to 0.30.6 #738

merged 3 commits into from
Jul 18, 2023

Conversation

lubronzhan
Copy link
Contributor

What this PR does / why we need it:
Need govmomi fix vmware/govmomi#3174 for validating certificate's tlsthumbprint to work properly

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes ##736

Special notes for your reviewer:

Release note:

Bump govmomi to 0.30.6

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2023
@lubronzhan lubronzhan force-pushed the topic/bump_govmomi_0.30.6 branch from 93de6f4 to 37c577b Compare July 18, 2023 17:59
@HanFa
Copy link
Member

HanFa commented Jul 18, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HanFa, lubronzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit d0c39a6 into kubernetes:master Jul 18, 2023
@liggitt
Copy link
Member

liggitt commented Sep 14, 2023

Does this also need to be updated in kubernetes/kubernetes for go1.20? That is still using v0.30.0 (see kubernetes/kubernetes#114766 and backports)

@liggitt
Copy link
Member

liggitt commented Sep 14, 2023

cc @MadhavJivrajani

@lubronzhan
Copy link
Contributor Author

cc @wyike it should be needed

@MadhavJivrajani
Copy link

MadhavJivrajani commented Sep 15, 2023 •
edited
Loading

@liggitt I think we'll have to bump and back-port. This issue didn't surface directly in our CI.

We did a similar fix but in our tests: kubernetes/kubernetes@c31cc5e
and the reason it worked in our CI was because the function being fixed relies on text matching in the error string.

MadhavJivrajani added a commit to MadhavJivrajani/kubernetes that referenced this pull request Sep 18, 2023
@MadhavJivrajani
.: bump govmomi to v0.30.6
fc6b19a 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 18, 2023
Merged
MadhavJivrajani added a commit to MadhavJivrajani/kubernetes that referenced this pull request Sep 20, 2023
@MadhavJivrajani
.: bump govmomi to v0.30.6
7551dec 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 20, 2023
Merged
MadhavJivrajani added a commit to MadhavJivrajani/kubernetes that referenced this pull request Sep 20, 2023
@MadhavJivrajani
.: bump govmomi to v0.30.6
0dc2f88 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 20, 2023
Merged
MadhavJivrajani added a commit to MadhavJivrajani/kubernetes that referenced this pull request Sep 20, 2023
@MadhavJivrajani
.: bump govmomi to v0.30.6
ecf1a9d 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 20, 2023
Merged
MadhavJivrajani added a commit to MadhavJivrajani/kubernetes that referenced this pull request Sep 20, 2023
@MadhavJivrajani
.: bump govmomi to v0.30.6
ef63f36 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani mentioned this pull request Sep 20, 2023
Merged
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Sep 20, 2023
@MadhavJivrajani @k8s-publishing-bot
.: bump govmomi to v0.30.6
f48d4dd 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>

Kubernetes-commit: fc6b19a4ba669da7a55f0c061f465fdfe4510720
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Sep 20, 2023
@MadhavJivrajani @k8s-publishing-bot
.: bump govmomi to v0.30.6
dd98257 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>

Kubernetes-commit: 7551decb3fe44014ce982d78a7bd3ab352332b30
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Sep 20, 2023
@MadhavJivrajani @k8s-publishing-bot
.: bump govmomi to v0.30.6
658198b 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>

Kubernetes-commit: 0dc2f88f546a83ec7166f19c7cb37d8c70cdeeb7
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Sep 20, 2023
@MadhavJivrajani @k8s-publishing-bot
.: bump govmomi to v0.30.6
7da5c95 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>

Kubernetes-commit: ecf1a9de9651053b285e909bfbf8e493080a6c5f
k8s-publishing-bot pushed a commit to kubernetes/legacy-cloud-providers that referenced this pull request Sep 20, 2023
@MadhavJivrajani @k8s-publishing-bot
.: bump govmomi to v0.30.6
7634e31 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>

Kubernetes-commit: ef63f36ff8297f47c9fe232836f0ed859f3ccf85
Sharpz7 pushed a commit to Sharpz7/kubernetes that referenced this pull request Oct 27, 2023
@MadhavJivrajani @Sharpz7
.: bump govmomi to v0.30.6
9ed4113 
Bumping govmomi to include an error check fix needed
to work with go1.20. We made this fix in the CI, but
were reliant on the text matching of error strings,
which is why it didn't catch the actual issue. This

Fix in vmware/govmomi@b4eac19
PR to bump govmomi in cloud-provider-vsphere: kubernetes/cloud-provider-vsphere#738

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maplain maplain Awaiting requested review from maplain

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

Assignees

@HanFa HanFa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@lubronzhan @HanFa @k8s-ci-robot @liggitt @MadhavJivrajani