Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Updates to Include Helm Instructions #280

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

davidvonthenen
Copy link
Contributor

What this PR does / why we need it:
It's a quickstart guide to deploy the vSphere CPI using Helm! Links to this guide have also been updated on the README for the project for easy access.

Which issue this PR fixes:
NA

Special notes for your reviewer:
The Helm chart has already been published in the Charts repo. These instructions will work out of the gate.

Release note:
NA

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2019
Fix markdown issues
@davidvonthenen
Copy link
Contributor Author

cc: @frapposelli

@frapposelli
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit f5df58c into kubernetes:master Dec 16, 2019
@davidvonthenen davidvonthenen deleted the feature/helmdocs branch January 15, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants