Fix failing go test in connection_test.go

[davidvonthenen]

What this PR does / why we need it:
Just like it sounds... it's a port of this fix https://github.com/kubernetes/kubernetes/pull/81390/files#diff-a0b58bcaae491877d401a6a7011882f3L159

Which issue this PR fixes: NA

Special notes for your reviewer:
NA

Release note:
NA

[andrewsykim]

/approve

(squash last commit please)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewsykim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidvonthenen]

This PR fixes the pull-cloud-provider-vsphere-unit-test that was failing thanks to @dougm.

I asked @codenrhoden to take a look at the pull-cloud-provider-vsphere-integration-test since I don't really know much about the CI stuff and how it was setup. It looks like it's failing because of a docker issue or possibility an integration test that happens to be using docker.

[dougm]

/lgtm

[codenrhoden]

I asked @codenrhoden to take a look at the pull-cloud-provider-vsphere-integration-test since I don't really know much about the CI stuff and how it was setup. It looks like it's failing because of a docker issue or possibility an integration test that happens to be using docker.

I have a plan for how to fix this. Going to take me a bit of time (mixing it in with other priorities). It should make the integration pre-submit quite a bit more stable, I believe. However, there will still be an issue with the periodic conformance tests -- those are red across the board and need to be revisited completely. I can explain that issue when I open the PR to fix integration tests.

[davidvonthenen]

I asked @codenrhoden to take a look at the pull-cloud-provider-vsphere-integration-test since I don't really know much about the CI stuff and how it was setup. It looks like it's failing because of a docker issue or possibility an integration test that happens to be using docker.

I have a plan for how to fix this. Going to take me a bit of time (mixing it in with other priorities). It should make the integration pre-submit quite a bit more stable, I believe. However, there will still be an issue with the periodic conformance tests -- those are red across the board and need to be revisited completely. I can explain that issue when I open the PR to fix integration tests.

No worries! Thanks for your help!

[davidvonthenen]

/retest

[codenrhoden]

woohoo! 🎉
/honk

[k8s-ci-robot]

@codenrhoden:

In response to this:

woohoo! 🎉
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.