issues with vcenter fqdns that contains uppercase

[yastij]

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

it seems like we are lower casing the vcenter fqdn before storing in the cache

cloud-provider-vsphere/pkg/common/credentialmanager/credentialmanager.go

Lines 196 to 208 in 6872a0b

	credentialKey = strings.ToLower(credentialKey)
	if strings.HasSuffix(credentialKey, "password") {
	vcServer := strings.Split(credentialKey, ".password")[0]
	if _, ok := config[vcServer]; !ok {
	config[vcServer] = &Credential{}
	}
	config[vcServer].Password = string(credentialValue)
	} else if strings.HasSuffix(credentialKey, "username") {
	vcServer := strings.Split(credentialKey, ".username")[0]
	if _, ok := config[vcServer]; !ok {
	config[vcServer] = &Credential{}
	}
	config[vcServer].User = string(credentialValue)

, but when trying to access credentials we are using vcenter fqdn as is, see:

cloud-provider-vsphere/pkg/common/connectionmanager/connectionmanager.go

Line 160 in 6872a0b

credentials, err := credMgr.GetCredential(vcInstance.Cfg.VCenterIP)

,

/assign @dvonthenen

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• vsphere-cloud-controller-manager version:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[davidvonthenen]

Thanks @yastij for catching this!

[vuil]

@dvonthenen is this an issue that will be addressed soon? Look for guidance on whether we need to address TKG-2098.

[davidvonthenen]

The PR (above) to fix this was opened the same day the issue was filed. Just waiting for feedback or a merge on this PR in order to close this out.

[davidvonthenen]

/close

[k8s-ci-robot]

@dvonthenen: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.