Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsphere secret #265

Closed
kfox1111 opened this issue Oct 10, 2019 · 5 comments
Closed

vsphere secret #265

kfox1111 opened this issue Oct 10, 2019 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kfox1111
Copy link

The documentation mentions putting credentials in a configmap. Its best practice to put them in secrets.

@davidvonthenen
Copy link
Contributor

davidvonthenen commented Oct 11, 2019

Yea, the documentation should definitely document using k8s secret since the CPI supports it. Will make the change to the docs.

@kfox1111 You can find the docs for using secrets here on the CPI:
https://github.com/kubernetes/cloud-provider-vsphere/blob/6a93718c440343b65970f8a0bcdaaecff04a02b6/docs/book/tutorials/deploying_cloud_provider_vsphere_with_rbac.md

After you configure the CPI, continue on using the current docs to configure CSI.

/assign
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 11, 2019
@davidvonthenen
Copy link
Contributor

davidvonthenen commented Oct 11, 2019

PR submitted. #267

@kfox1111 That should at least get you going if you haven't done so already.

@davidvonthenen
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@dvonthenen: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kfox1111
Copy link
Author

Great. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants