-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify hostAliases in the cinder-csi-plugin nodeplugin-daemonset #2385
Conversation
|
Welcome @mp1-nathan-grey! |
Hi @mp1-nathan-grey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mp1-nathan-grey thanks for the PR. Can you add these fields to other charts and bump a chart version? |
@kayrus I included the hostAliases in the other charts, bumped all versions, and corrected the linting errors I had. Thanks for your review! |
Can you squash the commits? Then I think this is good to go. |
/ok-to-test |
commented examples
Submitted the squashed commit, thanks |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…th (kubernetes#2385) commented examples
What this PR does / why we need it:
This PR allows to specify hostAliases in the nodeplugin-daemonset to allow for setting custom hosts. This functionality is off by default in the PR and has appropriate comments to structure and enable.
The reason for submitting this PR is because this chart is not using hosts from coredns' corefile.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: