-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small documentation changes to warn users about deploying VPA with leader election on GKE. #7462
Conversation
/assign @adrianmoisey |
/lgtm Thanks for making this PR |
Is it worth also updating https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler#known-limitations to be super loud and clear about the issue? |
@raywainman, please address the following failed test case |
/lgtm cancel removing lgtm, as the required test case has failed. |
/lgtm |
Thanks @raywainman |
…cific content there
Discussed with @kwiesmueller and we agreed I would remove the comment in |
/assign @kwiesmueller |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwiesmueller, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates documentation to warn and inform users about how to properly use leader election in GKE when deploying their own VPA recommender.
Which issue(s) this PR fixes:
#7461