vpa-recommender: Use the MaintainCheckpoints context only for that step #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/vertical-pod-autoscaler
size/S
ialidzhikov
force-pushed
the
fix/vpa-recommender-context
branch
from
640a546 to
9c16c99
Compare
k8s-ci-robot
added
size/XS
|
/lgtm good catch, thanks for fixing it so quickly! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
What this PR does / why we need it:
In https://github.com/kubernetes/autoscaler/pull/6899/files#diff-5c44f22eb0f35931ab799838d2584dd10037916c74f114124e6904af48fcd608R157, I wrongly passed a context that is specific only to the
MaintainCheckpointsstep to 2 other steps:LoadVPAsandGarbageCollect.This PR reverts to the old behaviour where the context with timeout of 1min by default was used only for the
MaintainCheckpointsstep.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: