Prov req client #6104
Merged
Prov req client #6104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
area/cluster-autoscaler
size/XXL
|
/assign @mwielgus |
kisieland
force-pushed
the
prov-req-client
branch
2 times, most recently
from
f8f10c6 to
2b54ea0
Compare
kisieland
force-pushed
the
prov-req-client
branch
from
2b54ea0 to
6a6229e
Compare
Manifest generated via: $ make manifest Client generated via: $ ./hack/update-codegen.sh
kisieland
force-pushed
the
prov-req-client
branch
from
6a6229e to
fd13a4c
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kisieland, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
liggitt
reviewed
Sep 14, 2023
cluster-autoscaler/config/crd/provisioning.k8s.io_provisioningrequests.yaml
Show resolved
Hide resolved
liggitt
reviewed
Sep 14, 2023
cluster-autoscaler/config/crd/provisioning.k8s.io_provisioningrequests.yaml
Show resolved
Hide resolved
liggitt
reviewed
Sep 14, 2023
cluster-autoscaler/config/crd/provisioning.k8s.io_provisioningrequests.yaml
Show resolved
Hide resolved
|
/assign @liggitt |
liggitt
reviewed
Sep 14, 2023
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequests/apis/provisioning.k8s.io/v1beta1/types.go
Show resolved
Hide resolved
kisieland
added a commit
to kisieland/autoscaler
that referenced
this pull request
Sep 19, 2023
kisieland
added a commit
to kisieland/autoscaler
that referenced
this pull request
Sep 19, 2023
kisieland
added a commit
to kisieland/autoscaler
that referenced
this pull request
Sep 20, 2023
kisieland
added a commit
to kisieland/autoscaler
that referenced
this pull request
Sep 20, 2023
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 20, 2023
Address comments from #6104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a definition of Provisioning Request that was proposed in #5848.
PR also adds mechanisms to generate a CRD yaml file and client to interact with the Provisioning Request objects.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
The PR consists of 3 commints:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: