Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci provider: fail fast, recover fast, when instance-pool/node-group is out of capacity #5335

Conversation

jlamillan
Copy link
Contributor

Which component this PR applies to?

cluster-autoscaler (OCI provider)

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support to the OCI provider for Instance Pools to fail fast (and potentially recover fast) when an underlying instance-pool for a node-group has run out of quota / capacity.

It accomplishes this by taking a similar approach to this PR where it monitors the cloud-providers work request queue for errors relating to capacity/quota, and quickly fails any on-going scale-up operation if they are detected. Additionally, it creates "placeholder instances" for yet-to-be-fulfilled cloud instances, which allows the Cluster Autoscaler to short-circuit the --max-node-provision-time timeout and gives it (unfulfilled) instances to delete. This approach frees the Cluster Autoscaler to (1) detect the failure fast and (2) try to scale a different node-group to fulfill the missing instances (provided it meets the node requirements).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • These changes have been running in production for a number of weeks.

Does this PR introduce a user-facing change?

support monitoring instance-pool work-requests for capacity/quota issues during scale-up

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2022
@jlamillan
Copy link
Contributor Author

FYI @gjtempleton, @x13n thanks for mentioning that AWS and GKE take a similar approach the other week in the Autoscaling SIG.

@jlamillan jlamillan force-pushed the jlamillan/oci-provider-fail-fast-capacity branch from f0d25c6 to fd3fbd0 Compare November 29, 2022 22:24
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlamillan, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3806348 into kubernetes:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants