oci provider: fail fast, recover fast, when instance-pool/node-group is out of capacity #5335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler (OCI provider)
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support to the OCI provider for Instance Pools to fail fast (and potentially recover fast) when an underlying instance-pool for a node-group has run out of quota / capacity.
It accomplishes this by taking a similar approach to this PR where it monitors the cloud-providers work request queue for errors relating to capacity/quota, and quickly fails any on-going scale-up operation if they are detected. Additionally, it creates "placeholder instances" for yet-to-be-fulfilled cloud instances, which allows the Cluster Autoscaler to short-circuit the
--max-node-provision-time
timeout and gives it (unfulfilled) instances to delete. This approach frees the Cluster Autoscaler to (1) detect the failure fast and (2) try to scale a different node-group to fulfill the missing instances (provided it meets the node requirements).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?