Base parallel scale down implementation #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
x13n
force-pushed
the
scaledown6
branch
2 times, most recently
from
340b3f3 to
d8b1cf6
Compare
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
x13n
force-pushed
the
scaledown6
branch
2 times, most recently
from
b8cf070 to
9ed75f1
Compare
k8s-ci-robot
added
size/XL
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
towca
reviewed
Oct 21, 2022
|
Thanks for addressing the comments, LGTM! Just 1 nit, feel free to unhold if you prefer not to address. /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
Base parallel scale down implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
Core part of #5079 implementation.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a follow-up to #5161. Only last commit should be reviewed as a part of this PR. It will be on hold until the previous one is merged.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/hold
/assign @MaciekPytel @yaroslava-serdiuk