Update Cluster Autoscaler to go 1.17 #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm nit: It might be worth pointing out the difference in comments somewhere (e.g. add a comment to the Dockerfile saying that this should be the authoritative version and why it's different than go.mod + an opposite comment in go.mod). I know I've been using the version from go.mod as the authoritative one so far, others might be surprised as well. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Kubernetes 1.23 uses that version and the vendored code no longer compiles using go1.16 (which we used previously). Following the upstream Kubernetes I'm leaving the go version in go.mod file at 1.16, as bumping it to 1.17 changes go mod behavior in a way that breaks some kubernetes tooling (kubernetes/kubernetes#105563 (comment) for context).
CA no longer compiles on go1.16.
As of go1.17 both tags are expected to exist simultaneously. Added tags in all cluster autoscaler files. Added verify-gomod.sh exceptions for non-compliant autogenerated VPA files.
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial cherry-pick of a #4567.
Kubernetes has moved to go 1.17 and no longer compiles on go 1.16 (currently used by CA). This bumps CA to go1.17 and is a prerequisite to updating deps (which I'll do in a follow-up PR).
Some gotchas: