Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Pod Autoscaler release 0.9.1 #3743

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Vertical Pod Autoscaler release 0.9.1 #3743

merged 1 commit into from
Dec 7, 2020

Conversation

jbartosik
Copy link
Collaborator

To include #3729

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@jbartosik
Copy link
Collaborator Author

@bskiba please take a look

@bskiba
Copy link
Member

bskiba commented Dec 4, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba, jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbartosik
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2020
@jbartosik
Copy link
Collaborator Author

There is one more change I think I might want to have in the release. Putting on hold until I check

@jbartosik
Copy link
Collaborator Author

I would like to get #3744 in (and cherry pick it into this branch) before cutting the next release

@jbartosik
Copy link
Collaborator Author

#3744 merged, now I want to cherry pick it into the 0.9 branch (#3748) and then cancel the hold

@jbartosik
Copy link
Collaborator Author

#3748 merged

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f481ee into kubernetes:vpa-release-0.9 Dec 7, 2020
@johanneswuerbach
Copy link
Contributor

It looks like this release never went out, should it already be pushed?

@jbartosik jbartosik deleted the vpa-release-0.9.1 branch January 15, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysied krzysied Awaiting requested review from krzysied

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbartosik @bskiba @k8s-ci-robot @johanneswuerbach