Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraVolumeSecrets chart value #3692

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Add extraVolumeSecrets chart value #3692

merged 1 commit into from
Dec 3, 2020

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Nov 13, 2020

This value can be used to render volumes and volumeMounts.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2020
gjtempleton
gjtempleton reviewed Nov 15, 2020
View reviewed changes
charts/cluster-autoscaler-chart/values.yaml Outdated
@@ -150,6 +150,9 @@ extraArgs:
# extraEnv -- Additional container environment variables.
extraEnv: {}

# extraVolumeSecrets -- Additional volumes to mount from Secrets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a full example of using this commented out given there's a number of sub-options here please.

@gjtempleton
Copy link
Member

Hey, thanks for the PR!

One request for you from a first look over it.

@avorima avorima force-pushed the chart/extra-volumes branch from 37774b9 to a3e4cbf Compare November 16, 2020 11:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2020
@avorima avorima requested a review from gjtempleton November 17, 2020 10:30
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2020
@avorima avorima force-pushed the chart/extra-volumes branch from a3e4cbf to e166237 Compare November 23, 2020 20:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2020
@avorima avorima force-pushed the chart/extra-volumes branch from e166237 to d30997e Compare November 24, 2020 11:27
@foriequal0
Copy link
Contributor

I've found that my PR will conflict with this: #3725

@avorima
Copy link
Contributor Author

avorima commented Nov 27, 2020

@foriequal0 My intent is that extra volumes and volumeMounts can be added for any cloud provider, so I'd prefer not to move it into an else if-block

gjtempleton
gjtempleton reviewed Dec 1, 2020
View reviewed changes
charts/cluster-autoscaler/Chart.yaml Outdated
@@ -17,4 +17,4 @@ name: cluster-autoscaler
sources:
- https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler
type: application
version: 9.1.0
version: 9.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we stuck to SemVer here and bumped the minor version as new functionality is being added

@avorima
Add extraVolumeSecrets chart value
5cd7fba 
This value can be used to render `volumes` and `volumeMounts`.
@avorima avorima force-pushed the chart/extra-volumes branch from d30997e to 5cd7fba Compare December 1, 2020 13:39
@avorima avorima requested a review from gjtempleton December 1, 2020 13:43
@gjtempleton
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avorima, gjtempleton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit b201c8d into kubernetes:master Dec 3, 2020
@foriequal0 foriequal0 mentioned this pull request Dec 3, 2020
Merged
@avorima avorima deleted the chart/extra-volumes branch December 3, 2020 10:11
@gjtempleton gjtempleton mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avorima @gjtempleton @foriequal0 @k8s-ci-robot