cherry pick: "Fix nvidia gpu resource name on AWS" to 1.1 #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
When will this merge be performed? I'm having issue with version 1.1.1 of ASG. |
|
/lgtm A word of caution - regardless of this fix CA only works correctly with GPU in GCP/GKE. For other providers it will create too many nodes with GPU when scaling-up due to kubernetes/kubernetes#54959. We still don't have a generic fix for this issue, due to reasons explained in my comment #597 (comment). |
k8s-ci-robot
added
the
lgtm
yaroslava-serdiuk
pushed a commit
to yaroslava-serdiuk/autoscaler
that referenced
this pull request
Feb 22, 2024
Bumps [k8s.io/component-base](https://github.com/kubernetes/component-base) from 0.27.5 to 0.27.6. - [Commits](kubernetes/component-base@v0.27.5...v0.27.6) --- updated-dependencies: - dependency-name: k8s.io/component-base dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick of:
#648