Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure InstanceType case sensitive #1608

Closed
suker200 opened this issue Jan 24, 2019 · 3 comments · Fixed by #2026
Closed

Azure InstanceType case sensitive #1608

suker200 opened this issue Jan 24, 2019 · 3 comments · Fixed by #2026

Comments

@suker200
Copy link

Hi,
I met an issue relate to case sensitive instance type in Azure response.

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/azure/azure_scale_set.go#L429
https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/azure/azure_instance_types.go#L640

The value of "*template.Sku.Name" is : Standard_D8_V3
But the key of "InstanceTypes" is: Standard_D8_v3

It made cluster autoscaler failed.

I have workaround add

	"Standard_D8_v3": {
		InstanceType: "Standard_D8_v3",
		VCPU:         8,
		MemoryMb:     32768,
		GPU:          0,
	},
	"Standard_D8_V3": {
		InstanceType: "Standard_D8_V3",
		VCPU:         8,
		MemoryMb:     32768,
		GPU:          0,
	},

to "InstanceTypes" and cluster-autoscaler works as normal

@feiskyer
Copy link
Member

feiskyer commented Feb 1, 2019

@suker200 Thanks for reporting the issue. This should be fixed within CA. Would file a PR to fix it.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2019
@feiskyer
Copy link
Member

feiskyer commented May 2, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2019
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this issue Feb 22, 2024
…ubernetes#1608)

* Add an exponential backoff mechanism to the requeueing strategy

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>

* Rephrase 'maxBackOffRetry' with 'backOffLimit'

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Improve expressions

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Move backOffLimitTimeout to an alternative section

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Replace backOff with backoff

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Additional eviction reasons to story 2

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Update an API comment for backoffLimitCount

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Update story3

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Move backoffTimeout to an alternative section

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Update workload API

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Rephrase strory2

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

---------

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants